From c5866f3617c8c37b1461411e39bf1876cd2e65be Mon Sep 17 00:00:00 2001
From: Bram Suurd <78373894+BramSuurdje@users.noreply.github.com>
Date: Fri, 27 Jun 2025 19:38:06 +0000
Subject: [PATCH] Enhance CommandMenu to prevent duplicate scripts across
 categories

---
 frontend/src/components/command-menu.tsx | 76 +++++++++++++++---------
 1 file changed, 48 insertions(+), 28 deletions(-)

diff --git a/frontend/src/components/command-menu.tsx b/frontend/src/components/command-menu.tsx
index bd3945848..e23933a83 100644
--- a/frontend/src/components/command-menu.tsx
+++ b/frontend/src/components/command-menu.tsx
@@ -139,34 +139,54 @@ export default function CommandMenu() {
         <CommandInput placeholder="Search for a script..." />
         <CommandList>
           <CommandEmpty>{isLoading ? "Loading..." : "No scripts found."}</CommandEmpty>
-          {links.map(category => (
-            <CommandGroup key={`category:${category.name}`} heading={category.name}>
-              {category.scripts.map(script => (
-                <CommandItem
-                  key={`script:${script.slug}`}
-                  value={`${script.slug}-${script.name}`}
-                  onSelect={() => {
-                    setOpen(false);
-                    router.push(`/scripts?id=${script.slug}`);
-                  }}
-                >
-                  <div className="flex gap-2" onClick={() => setOpen(false)}>
-                    <Image
-                      src={script.logo || `/${basePath}/logo.png`}
-                      onError={e => ((e.currentTarget as HTMLImageElement).src = `/${basePath}/logo.png`)}
-                      unoptimized
-                      width={16}
-                      height={16}
-                      alt=""
-                      className="h-5 w-5"
-                    />
-                    <span>{script.name}</span>
-                    <span>{formattedBadge(script.type)}</span>
-                  </div>
-                </CommandItem>
-              ))}
-            </CommandGroup>
-          ))}
+          {(() => {
+            // Track seen scripts globally to avoid duplicates across all categories
+            const globalSeenScripts = new Set<string>();
+
+            return links.map((category) => {
+              const uniqueScripts = category.scripts.filter((script) => {
+                if (globalSeenScripts.has(script.slug)) {
+                  return false;
+                }
+                globalSeenScripts.add(script.slug);
+                return true;
+              });
+
+              // Only render category if it has unique scripts
+              if (uniqueScripts.length === 0) {
+                return null;
+              }
+
+              return (
+                <CommandGroup key={`category:${category.name}`} heading={category.name}>
+                  {uniqueScripts.map(script => (
+                    <CommandItem
+                      key={`script:${script.slug}`}
+                      value={`${script.slug}-${script.name}`}
+                      onSelect={() => {
+                        setOpen(false);
+                        router.push(`/scripts?id=${script.slug}`);
+                      }}
+                    >
+                      <div className="flex gap-2" onClick={() => setOpen(false)}>
+                        <Image
+                          src={script.logo || `/${basePath}/logo.png`}
+                          onError={e => ((e.currentTarget as HTMLImageElement).src = `/${basePath}/logo.png`)}
+                          unoptimized
+                          width={16}
+                          height={16}
+                          alt=""
+                          className="h-5 w-5"
+                        />
+                        <span>{script.name}</span>
+                        <span>{formattedBadge(script.type)}</span>
+                      </div>
+                    </CommandItem>
+                  ))}
+                </CommandGroup>
+              );
+            });
+          })()}
         </CommandList>
       </CommandDialog>
     </>