[GH] Remove unwanted output from script test workflow (#2337)

* Remove unwanted output from workflow

* Remove unwanted output from workflow

* update .yml so it supports external repos

* update .yml so it supports external repos

.github/workflows/scripts/app-test/pr-build.func

@@ -1,12 +1,11 @@
 #!/usr/bin/env bash
 # Copyright (c) 2021-2025 community-scripts ORG
-# Author: michelroegl-brunner
+# Author: Michel Roegl-Brunner (michelroegl-brunner)
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 
 variables() {
-  NSAPP=$(echo ${APP,,} | tr -d ' ') 
-  var_install="${NSAPP}-install"     
-
+  NSAPP=$(echo ${APP,,} | tr -d ' ') # This function sets the NSAPP variable by converting the value of the APP variable to lowercase and removing any spaces.
+  var_install="${NSAPP}-install"     # sets the var_install variable by appending "-install" to the value of NSAPP.
 }
 
 NEXTID=$(pvesh get /cluster/nextid)
@@ -16,7 +15,7 @@ header_info(){
 }
 
 base_settings() {
-  
+  # Default Settings
   CT_TYPE="1"
   DISK_SIZE="4"
   CORE_COUNT="1"
@@ -40,7 +39,7 @@ base_settings() {
   SSH_AUTHORIZED_KEY=""
   TAGS="community-script;"
 
-  
+  # Override default settings with variables from ct script
   CT_TYPE=${var_unprivileged:-$CT_TYPE}
   DISK_SIZE=${var_disk:-$DISK_SIZE}
   CORE_COUNT=${var_cpu:-$CORE_COUNT}
@@ -48,6 +47,7 @@ base_settings() {
   VERB=${var_verbose:-$VERBOSE}
   TAGS="${TAGS}${var_tags:-}"
 
+  # Since these 2 are only defined outside of default_settings function, we add a temporary fallback. TODO: To align everything, we should add these as constant variables (e.g. OSTYPE and OSVERSION), but that would currently require updating the default_settings function for all existing scripts
   if [ -z "$var_os" ]; then
     var_os="debian"
   fi
@@ -112,10 +112,9 @@ error_handler() {
   SCRIPT_NAME=$(basename "$0")
   local error_message="$SCRIPT_NAME: Failure in line $line_number while executing command $command"
   echo -e "\n$error_message"
-  exit "$error_message"
+  exit 100
 }
 
-
 msg_info() {
   local msg="$1"
   echo -ne "${msg}\n"
@@ -136,7 +135,8 @@ start(){
 }
 
 build_container() {
- 
+  #  if [ "$VERB" == "yes" ]; then set -x; fi
+
   if [ "$CT_TYPE" == "1" ]; then
     FEATURES="keyctl=1,nesting=1"
   else

.github/workflows/scripts/app-test/pr-create-lxc.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 # Copyright (c) 2021-2025 community-scripts ORG
-# Author: michelroegl-brunner
+# Author: Michel Roegl-Brunner (michelroegl-brunner)
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 
 color() {
@@ -11,7 +11,6 @@ catch_errors() {
   trap 'error_handler $LINENO "$BASH_COMMAND"' ERR
 }
 
-
 error_handler() {
     local exit_code="$?"
   local line_number="$1"
@@ -68,6 +67,7 @@ function select_storage() {
   *) false || { msg_error "Invalid storage class."; exit 201; };;
   esac
   
+  # This Queries all storage locations
   local -a MENU
   while read -r line; do
     local TAG=$(echo $line | awk '{print $1}')
@@ -81,6 +81,7 @@ function select_storage() {
     MENU+=("$TAG" "$ITEM" "OFF")
   done < <(pvesm status -content $CONTENT | awk 'NR>1')
   
+  # Select storage location
   if [ $((${#MENU[@]}/3)) -eq 1 ]; then
     printf ${MENU[0]}
   else
@@ -103,17 +104,12 @@ if pct status $CTID &>/dev/null; then
   exit 206
 fi
 
-
 TEMPLATE_STORAGE=$(select_storage template) || exit
-msg_ok "Using  $TEMPLATE_STORAGE   for Template Storage."
-
 
 CONTAINER_STORAGE=$(select_storage container) || exit
-msg_ok "Using  $CONTAINER_STORAGE   for Container Storage."
 
-msg_info "Updating LXC Template List"
 pveam update >/dev/null
-msg_ok "Updated LXC Template List"
+
 
 TEMPLATE_SEARCH=${PCT_OSTYPE}-${PCT_OSVERSION:-}
 mapfile -t TEMPLATES < <(pveam available -section system | sed -n "s/.*\($TEMPLATE_SEARCH.*\)/\1/p" | sort -t - -k 2 -V)
@@ -124,35 +120,29 @@ TEMPLATE_PATH="/var/lib/vz/template/cache/$TEMPLATE"
 
 if ! pveam list "$TEMPLATE_STORAGE" | grep -q "$TEMPLATE"; then
   [[ -f "$TEMPLATE_PATH" ]] && rm -f "$TEMPLATE_PATH"
-  msg_info "Downloading LXC Template"
   pveam download "$TEMPLATE_STORAGE" "$TEMPLATE" >/dev/null ||
     { msg_error "A problem occurred while downloading the LXC template."; exit 208; }
-  msg_ok "Downloaded LXC Template"
 fi
 
 
 grep -q "root:100000:65536" /etc/subuid || echo "root:100000:65536" >> /etc/subuid
 grep -q "root:100000:65536" /etc/subgid || echo "root:100000:65536" >> /etc/subgid
 
-
 PCT_OPTIONS=(${PCT_OPTIONS[@]:-${DEFAULT_PCT_OPTIONS[@]}})
 [[ " ${PCT_OPTIONS[@]} " =~ " -rootfs " ]] || PCT_OPTIONS+=(-rootfs "$CONTAINER_STORAGE:${PCT_DISK_SIZE:-8}")
 
-echo "${PCT_OPTIONS[@]}"
 
-
-msg_info "Creating LXC Container"
   if ! pct create "$CTID" "${TEMPLATE_STORAGE}:vztmpl/${TEMPLATE}" "${PCT_OPTIONS[@]}" &>/dev/null; then
       [[ -f "$TEMPLATE_PATH" ]] && rm -f "$TEMPLATE_PATH"
       
-    msg_ok "Template integrity check completed"
+
     pveam download "$TEMPLATE_STORAGE" "$TEMPLATE" >/dev/null ||    
       { msg_error "A problem occurred while re-downloading the LXC template."; exit 208; }
     
-    msg_ok "Re-downloaded LXC Template"
+
     if ! pct create "$CTID" "${TEMPLATE_STORAGE}:vztmpl/${TEMPLATE}" "${PCT_OPTIONS[@]}" &>/dev/null; then
         msg_error "A problem occurred while trying to create container after re-downloading template."
       exit 200
     fi
   fi
-msg_ok "LXC Container  $CTID   was successfully created."
+

.github/workflows/scripts/app-test/pr-install.func

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 # Copyright (c) 2021-2025 community-scripts ORG
-# Author: michelroegl-brunner
+# Author: Michel Roegl-Brunner (michelroegl-brunner)
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 
 color() {
@@ -11,13 +11,14 @@ catch_errors() {
   trap 'error_handler $LINENO "$BASH_COMMAND"' ERR
 }
 
+
 error_handler() {
   local line_number="$1"
   local command="$2"
   SCRIPT_NAME=$(basename "$0")
   local error_message="$SCRIPT_NAME: Failure in line $line_number while executing command $command"
   echo -e "\n$error_message"
-  exit "$error_message"
+  exit 200
 }
 verb_ip6() {
     STD=""
@@ -39,9 +40,11 @@ msg_error() {
   local msg="$1"
   echo -e "${msg}\n"
 }
-  RETRY_NUM=10
-  RETRY_EVERY=3
+
+RETRY_NUM=10
+RETRY_EVERY=3
 setting_up_container() {
+
   sed -i "/$LANG/ s/\(^# \)//" /etc/locale.gen
   locale_line=$(grep -v '^#' /etc/locale.gen | grep -E '^[a-zA-Z]' | awk '{print $1}' | head -n 1)
   echo "LANG=${locale_line}" >/etc/default/locale
@@ -54,7 +57,6 @@ setting_up_container() {
     if [ "$(hostname -I)" != "" ]; then
       break
     fi
-    echo 1>&2 -en "No Network! "
     sleep $RETRY_EVERY
   done
   if [ "$(hostname -I)" = "" ]; then
@@ -64,8 +66,6 @@ setting_up_container() {
   fi
   rm -rf /usr/lib/python3.*/EXTERNALLY-MANAGED
   systemctl disable -q --now systemd-networkd-wait-online.service
-  msg_ok "Set up Container OS"
-  msg_ok "Network Connected: $(hostname -I)"
 }
 
 network_check() {
@@ -75,11 +75,10 @@ network_check() {
 }
 
 update_os() {
-  msg_info "Updating Container OS"
-  apt-get update
-  apt-get -o Dpkg::Options::="--force-confold" -y dist-upgrade
-  rm -rf /usr/lib/python3.*/EXTERNALLY-MANAGED
-  msg_ok "Updated Container OS"
+  export DEBIAN_FRONTEND=noninteractive
+  apt-get update >/dev/null 2>&1
+  apt-get -o Dpkg::Options::="--force-confold" -y dist-upgrade  >/dev/null 2>&1
+  rm -rf /usr/lib/python3.*/EXTERNALLY-MANAGED  
 }
 
 motd_ssh() {